<html>
<head><meta charset="utf-8"><title>PR Concerns · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/PR.20Concerns.html">PR Concerns</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="224282903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/PR%20Concerns/near/224282903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> asquared31415 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/PR.20Concerns.html#224282903">(Jan 28 2021 at 04:22)</a>:</h4>
<p>I have some concerns with a PR that I am creating, namely trying to determine if there could be edge cases with a change I've made.  Would it be best to address these issues in the PR description, or in another comment.  Additionally, should I mark the PR as a draft until those concerns are resolved?</p>



<a name="224295333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/PR%20Concerns/near/224295333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/PR.20Concerns.html#224295333">(Jan 28 2021 at 08:15)</a>:</h4>
<blockquote>
<p>Would it be best to address these issues in the PR description, or in another comment.</p>
</blockquote>
<p>Both are ok.<br>
PR description goes into the merge commit message when the PR is merged though, so the PR description may need to be updated before the merge if some issues are addressed.</p>
<blockquote>
<p>Additionally, should I mark the PR as a draft until those concerns are resolved?</p>
</blockquote>
<p>We have  labels like <code>S-waiting-on-author</code>, <code>S-waiting-on-review</code> and others so GitHub's draft functionality is entirely redundant.</p>



<a name="224345622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/PR%20Concerns/near/224345622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> asquared31415 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/PR.20Concerns.html#224345622">(Jan 28 2021 at 15:51)</a>:</h4>
<p>Thank you!</p>



<a name="224411829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/PR%20Concerns/near/224411829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/PR.20Concerns.html#224411829">(Jan 28 2021 at 23:57)</a>:</h4>
<blockquote>
<p>We have labels like S-waiting-on-author, S-waiting-on-review and others so GitHub's draft functionality is entirely redundant.</p>
</blockquote>
<p>People still use GitHub's draft PRs to indicate something is work-in-progress though.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>